Skip to content

GH-49561: [C++][FlightRPC][ODBC] Use SQLWCHAR array for wide string literals in test suite#49562

Merged
lidavidm merged 1 commit intoapache:mainfrom
Bit-Quill:gh-49561-sqlwchar-array
Mar 24, 2026
Merged

GH-49561: [C++][FlightRPC][ODBC] Use SQLWCHAR array for wide string literals in test suite#49562
lidavidm merged 1 commit intoapache:mainfrom
Bit-Quill:gh-49561-sqlwchar-array

Conversation

@justing-bq
Copy link
Contributor

@justing-bq justing-bq commented Mar 19, 2026

Rationale for this change

We want to use a SQLWCHAR array for wide string literal inside our test suite instead of a SQLWCHAR vector.

What changes are included in this PR?

SQLWCHAR vector used for wide string literals are replaced with a SQLWCHAR array instead.
Columns tests were refactored to perform assertions over std::string equality rather than wide string equality.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@justing-bq justing-bq requested a review from lidavidm as a code owner March 19, 2026 20:13
@github-actions
Copy link

⚠️ GitHub issue #49444 has been automatically assigned in GitHub to PR creator.

@justing-bq justing-bq changed the title GH-49444: [C++][FlightRPC][ODBC] Use SQLWCHAR array for wide string literals in test suite GH-49561: [C++][FlightRPC][ODBC] Use SQLWCHAR array for wide string literals in test suite Mar 19, 2026
@github-actions
Copy link

⚠️ GitHub issue #49561 has been automatically assigned in GitHub to PR creator.

@justing-bq
Copy link
Contributor Author

@lidavidm @kou Please take a look when you have time.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Mar 24, 2026
@lidavidm lidavidm merged commit af184f5 into apache:main Mar 24, 2026
55 of 57 checks passed
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants